Code Inspection - Incorrect Diagnosis: Object variable is assigned without the Set keyword

[Stevefb]

In MS Word, cos ranges are different...

Sub ImTooLazy(aRange As Range)
aRange = "something"
End Sub

In this case the suggestion should have been working towards:
aRange.text = "something"

[ThunderFrame]

Attack of the Default member.

[Stevefb]

And another... @ThunderFrame should be new issue, or pile them all in here?

Private Sub UserForm_KeyDown(ByVal KeyCode As MSForms.ReturnInteger, ByVal Shift As Integer)
    If KeyCode = vbKeyF1 Then
        KeyCode = 0                                                ' <-- Should be KeyCode.Value = 0
    End If
End Sub

[ThunderFrame]

@Stevefb Issues should try to cover a class of problem rather than an issue for each instance. There are many, many VBA classes that have default members, so now that we know that default members remain problematic, a small number of examples is sufficient to define the problem.

Having said that, the MSForms.ReturnInteger only has one member and it is the default member, so it's a good candidate for testing.

[Stevefb]

Private Sub myTextBox_Exit(ByVal Cancel As MSForms.ReturnBoolean)
    If True Then
        Cancel = False  ' Should be Cancel.Value
    End If
End Sub

^^^^^ Funny, originally this Sub did not actually assign a value to Cancel. RD Flagged Cancel as Unused - so I used it...

[ThunderFrame]

that If True Then statement is looking a little redundant, but yes, ReturnBoolean would appear to be another class with a single (default) member.

So these all have a single member that is also the default member:

MSForms.ReturnBoolean
MSForms.ReturnEffect
MSForms.ReturnInteger
MSForms.ReturnSingle
MSForms.ReturnString

[Stevefb]

Yep. But it looked better than an empty Sub... (was just showing the context as I had it in my program)....

[retailcoder]

Oh wow. So what would be a good workaround here? Should we ignore types with a default property? or try to determine if the RHS expression is an object?

[retailcoder]

Hmm shouldn't the "parameter not used" inspection be not firing a result for handlers of built-in events?

[retailcoder]

One problem with default properties, at least in the Excel object model, is that what we see in the COM library is just _default instead of the actual property name: it's hard to tell exactly whether the _default member is expecting an object reference or a value. Perhaps we should just assume it's a value? I don't recall seeing any default property in the Excel object model being an object. So we could warn about implicit default member assignment I guess, and then have the object reference assigned without the Set keyword inspection ignore instances where the object in question is known to have a default property.