Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UseMeaningfulNameInspection should ignore parameter names in Declare Functions\Subs #2573

Closed
comintern opened this issue Jan 24, 2017 · 2 comments
Closed

UseMeaningfulNameInspection should ignore parameter names in Declare Functions\Subs #2573

comintern opened this issue Jan 24, 2017 · 2 comments
Assignees
@retailcoder
Labels
enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-inspections
Milestone
Release 2.0.12

Comments

@comintern
Copy link
Contributor

Take this example declaration:

Private Declare PtrSafe Function CLSIDFromString Lib "ole32" (ByVal lpsz As Any, ByRef pclsid As GUID) As Long

The parameter lpsz trips the UseMeaningfulNameInspection because it doesn't contain any vowels. I'd argue that code using the parameter names of external library procedures is "meaningful" in that it matches the documented signature of the function.
@retailcoder retailcoder added enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-inspections labels Jan 24, 2017
@retailcoder retailcoder self-assigned this Jan 24, 2017
@retailcoder
Copy link
Member

Mine! =)

@retailcoder
Copy link
Member

Fixed. Also won't trigger in built-in event handlers either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@retailcoder retailcoder

Labels
enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-inspections
Projects
None yet
Milestone
Release 2.0.12
Development

No branches or pull requests
2 participants
@retailcoder @comintern