Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ByVal parameter is assigned inspection fires even when parameter is an object. #2721

Closed
daFreeMan opened this issue Feb 22, 2017 · 2 comments
Labels
bug Identifies work items for known bugs duplicate Thanks for the feedback! We're already tracking this report/request at the linked issue. parse-tree-processing

Comments

@daFreeMan
Copy link
Contributor

Sub main()
  Dim Foo As Object
  Set Foo = New Object
  DoSomething Foo
End Sub

Sub DoSomething (ByVal Baz As Object)
  Baz.Bar = 'x'
End Sub

Baz.Bar = x triggers the ByVal parameter is assigned inspection. However, this is OK since Baz is an object and the result will show up at the call site as expected.

@retailcoder
Copy link
Member

Hmm, this feels like it could be the resolver annotating Baz with an IdentifierReference with the IsAssignmentTarget wrongly set to true.

@retailcoder retailcoder added bug Identifies work items for known bugs parse-tree-processing labels Feb 22, 2017
@comintern
Copy link
Contributor

This is a duplicate of #2601.

@comintern comintern added the duplicate Thanks for the feedback! We're already tracking this report/request at the linked issue. label Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies work items for known bugs duplicate Thanks for the feedback! We're already tracking this report/request at the linked issue. parse-tree-processing
Projects
None yet
Development

No branches or pull requests

3 participants