Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove module > export before removing = Yes > cancel saving #3561

Closed
IvenBach opened this issue Nov 23, 2017 · 4 comments · Fixed by #4661
Closed

Remove module > export before removing = Yes > cancel saving #3561

IvenBach opened this issue Nov 23, 2017 · 4 comments · Fixed by #4661
Assignees
Labels
bug Identifies work items for known bugs feature-code-explorer

Comments

@IvenBach
Copy link
Member

While deleting a module if you choose to export it and then subsequently cancel without saving, the module remains and is not Removeable. The option is grayed out and requires a reparse to enable the option again.

Version: 2.1.6535.41637

Status by design?

@Vogel612 Vogel612 added bug Identifies work items for known bugs feature-code-explorer labels Nov 23, 2017
@retailcoder
Copy link
Member

Sounds more like status missing a failing test ;-)

If the deletion was cancelled, RD state should ideally remain what it was before. Are we too eager to remove the module from parser state?

@retailcoder
Copy link
Member

Hold on - if the yes/no/cancel msgbox is ours, then we can fix it. If it's the VBE's, then it's essentially the same problem as when closing the last host document and then cancelling: the VBE unloads its add-ins and we never get to know about the cancellation... So that would be "by sorry design".

@MDoerner
Copy link
Contributor

I do not know what the code explorer does, but the parser really does not care whether something got removed directly. There is just a reparse that figures out what is in longer there by comparing the saves modules with those on the projects. So, I guess this is simply a problem about deactivating the command too early.

@kamocyc
Copy link

kamocyc commented Dec 13, 2017

The problem is resetting SelectedItem whether or not the item was actually removed in ExecuteRemoveComand method in CodeExplorerViewModel class.
So, even if the item was not removed, SelectedItem will become Project folder, therefore Remove command will not be enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies work items for known bugs feature-code-explorer
Projects
Development

Successfully merging a pull request may close this issue.

6 participants