Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RubberParserState should be refactored into RefactorCommandbase.cs abstract class #3567

Open
bclothier opened this issue Nov 25, 2017 · 0 comments
Open

RubberParserState should be refactored into RefactorCommandbase.cs abstract class #3567

bclothier opened this issue Nov 25, 2017 · 0 comments
Labels
difficulty-02-ducky Resolving these involves the internal API, but with relatively easy problems to solve. technical-debt This makes development harder or is leftover from a PullRequest. Needs to be adressed at some point.
Projects
CodeName: Cucumber

Comments

@bclothier
Copy link
Contributor

Currently the abstract class only requires IVBE, but from what I see, almost all, if not all, derived classes require the use of RubberParserState class, leading to duplicated code in all derived classes. That should be refactored into their abstract base class to cut down on the construction noise.
@Vogel612 Vogel612 added difficulty-02-ducky Resolving these involves the internal API, but with relatively easy problems to solve. technical-debt This makes development harder or is leftover from a PullRequest. Needs to be adressed at some point. labels Nov 25, 2017
@Vogel612 Vogel612 added this to TODO in CodeName: Cucumber Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty-02-ducky Resolving these involves the internal API, but with relatively easy problems to solve. technical-debt This makes development harder or is leftover from a PullRequest. Needs to be adressed at some point.
Projects
CodeName: Cucumber
  
TODO
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bclothier @Vogel612