Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating "Next" After Comment #4266

Closed
DevulskyA opened this issue Aug 10, 2018 · 2 comments
Closed

Creating "Next" After Comment #4266

DevulskyA opened this issue Aug 10, 2018 · 2 comments
Labels
duplicate Thanks for the feedback! We're already tracking this report/request at the linked issue. feature-autocomplete feature-block-completion AC issues specific to the "block completion" handler work-item Used for features not implemented to document requirements

Comments

@DevulskyA
Copy link

DevulskyA commented Aug 10, 2018

'BEFORE:

Option Explicit
Public myRibbon As IRibbonUI
Sub Onload(ribbon As IRibbonUI)
       'Create a ribbon instance for use in this project ' HIT ENTER HERE ->
       Set myRibbon = ribbon
End Sub

'AFTER:

Option Explicit
Public myRibbon As IRibbonUI
Sub Onload(ribbon As IRibbonUI)
       'Create a ribbon instance for use in this project ' HIT ENTER HERE->
       
       Next
       Set myRibbon = ribbon
End Sub
@retailcoder
Copy link
Member

Thanks for the feedback!

That's a known autocompletion issue... that an earlier PR meant to fix... except the current implementation isn't covered with unit tests and therefore prone to regression bugs - long story short, I'll be completing the rewrite of self-closing pairs first (decoupled from the codepane, with unit tests this time), and the subsequent following 2.2.x prereleases will no longer have block completion, until it's rewritten - this time leveraging the shiny new CodeStringParser, which will make block completion syntactically aware of the surroundings of the current line of code... which has very powerful implications =)

I take full ownership of this cowboying: autocompletion thoroughly nerd-sniped me, I whipped up a quick half-baked feature as soon as I could thinking I could get away with it, and the subtle challenges and complexities of it are making it utterly annoying to work with existing code. I'd recommend disabling all block completions for the time being; self-closing pairs aren't too bad, but backspacing to delete a ( or a " can be frustrating. "Smart Concat" works exactly as intended though.

@retailcoder retailcoder added bug Identifies work items for known bugs duplicate Thanks for the feedback! We're already tracking this report/request at the linked issue. feature-autocomplete support Whether you're using Rubberduck or you've forked it and have questions, never hesitate to ask! labels Aug 10, 2018
@retailcoder retailcoder added work-item Used for features not implemented to document requirements and removed bug Identifies work items for known bugs labels Aug 20, 2018
@retailcoder retailcoder added the feature-block-completion AC issues specific to the "block completion" handler label Oct 26, 2018
@bclothier bclothier removed the support Whether you're using Rubberduck or you've forked it and have questions, never hesitate to ask! label Aug 12, 2019
@bclothier
Copy link
Contributor

The issue was labeled as a duplicate but didn't link to one - going to link to #4676 and #4289 and use those instead and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Thanks for the feedback! We're already tracking this report/request at the linked issue. feature-autocomplete feature-block-completion AC issues specific to the "block completion" handler work-item Used for features not implemented to document requirements
Projects
None yet
Development

No branches or pull requests

3 participants