Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird placement of buttons on CE bar at certain sizes #4638

Closed
bclothier opened this issue Dec 14, 2018 · 3 comments · Fixed by #4661
Closed

Weird placement of buttons on CE bar at certain sizes #4638

bclothier opened this issue Dec 14, 2018 · 3 comments · Fixed by #4661
Assignees
@comintern
Labels
difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-code-explorer up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky user-interface This issue explicitly relates to the visible interface of Rubberduck.

Comments

@bclothier
Copy link
Contributor

I get that WPF will autohide controls that can't fit but I think this just looks too weird:
image

Kind of expect that the label and combobox would be a package deal.
@bclothier bclothier added enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. user-interface This issue explicitly relates to the visible interface of Rubberduck. feature-code-explorer up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. labels Dec 14, 2018
@mansellan
Copy link
Member

I wonder though, does this need to be permanently on show on the toolbar? Seems like Settings would be a better home for this, with a cog icon on the toolbar to jump there.

@retailcoder
Copy link
Member

I agree settings would be a better place for this. If it's not moved there, a fix to keep the label and dropdown together could be to simply wrap the two controls in a <StackPanel Orientation="Horizontal"> tag.

@bclothier
Copy link
Contributor Author

I agree that setting is also a better place but only if it affects more than just CE. Surely the font change would be useful everywhere, not just in CE, no?

@comintern comintern self-assigned this Dec 17, 2018
@comintern comintern mentioned this issue Dec 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comintern comintern

Labels
difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-code-explorer up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky user-interface This issue explicitly relates to the visible interface of Rubberduck.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code Explorer Extreme Makeover (for some values of extreme) comintern/Rubberduck
4 participants
@bclothier @retailcoder @comintern @mansellan