Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running tests by location #4704

Closed
bclothier opened this issue Jan 10, 2019 · 5 comments
Closed

Enable running tests by location #4704

bclothier opened this issue Jan 10, 2019 · 5 comments
Assignees
Labels
difficulty-02-ducky Resolving these involves the internal API, but with relatively easy problems to solve. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-unit-testing up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky
Milestone

Comments

@bclothier
Copy link
Contributor

In addition to category and selection, it should be possible (and hopefully trivial) to run tests based on their location (e.g. module they are in).

Originally posted by @bclothier in #4698 (comment)

@bclothier bclothier added enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-unit-testing up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky difficulty-02-ducky Resolving these involves the internal API, but with relatively easy problems to solve. labels Jan 10, 2019
@Vogel612
Copy link
Member

This is somewhat abstractable to running tests based on their current grouping in the grouping grid. As such we'd need a "Run Tests in Selected Group", where group would be any single of:

  • Location
  • Outcome
  • Category
  • ...?

@Irubataru
Copy link

I think that is what I suggested when I talked about it that it would be more versatile if you could run issues in the selected group. In that case it could also replace "Run selected category" (and invalidate #4703) as that functionality would be there if you chose to group by category.

@comintern
Copy link
Contributor

The problem inherent in this UI is that it kind of conflicts with "Run selected tests" if we're allowing multi-selection in the test grid (see #4701). If the user Ctrl selects multiple row in different groupings, then what exactly is the "Selected Group"? Both of them?

The menu on the toolbar currently gives the following options:

screenshot from 2019-02-02 12-54-46

Compare this to the options available in the VS "Run..." menu:

screenshot from 2019-02-02 12-56-35

The main difference is that VS also has context menus in its TreeView for running a selected node, whether or not it has sub-nodes. If it does have sub-nodes, it runs all of them.

The compromise here might be to just remove the "Selected Category" option from the toolbar completely (ref #4703) and change the "Selected Test" option to "Selected Tests" (plural). We could then add context menus on the grid expanders more fine grained control. Maybe something like:

Run Group
---------
Collapse
Expand

Individual tests could have context menus also, but I'm not sure what to put in them other than "Run Test" (although VS has an "Add to playlist option..." 😀 )

Thoughts?

@bclothier
Copy link
Contributor Author

FWIW as long we gain a right-click menu to run a test in a group (regardless of what the grouping is set), I think losing the Selected Category and having Run selected tests makes more sense and as a bonus simplify the UI. I'm for it.

@comintern
Copy link
Contributor

Closed via #4769.

@Vogel612 Vogel612 added this to Done in Release 2.4.1 Feb 28, 2019
@Vogel612 Vogel612 added this to the 2.4.1 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty-02-ducky Resolving these involves the internal API, but with relatively easy problems to solve. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-unit-testing up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky
Projects
No open projects
Release 2.4.1
  
Done
Development

No branches or pull requests

4 participants