Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings form fails to load with language codes that aren't implemented. #4818

Closed
comintern opened this issue Feb 22, 2019 · 1 comment
Closed

Settings form fails to load with language codes that aren't implemented. #4818

comintern opened this issue Feb 22, 2019 · 1 comment
Assignees
@comintern
Labels
bug Identifies work items for known bugs difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. feature-settings up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky
Milestone
2.4.1

Comments

@comintern
Copy link
Contributor

Pretty self explanatory. We have the UI cultures hard coded in a lookup without a check, so if the xml file uses a culture that isn't available in RD, the binder fails and the settings form doesn't load.

Can be reproduced with a settings file containing something like <Language Code="fu-br" />
@comintern comintern added bug Identifies work items for known bugs up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. feature-settings labels Feb 22, 2019
@bclothier
Copy link
Contributor

Ref comment from PR 4699

@comintern comintern self-assigned this Feb 26, 2019
@Vogel612 Vogel612 added this to the 2.4.1 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comintern comintern

Labels
bug Identifies work items for known bugs difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. feature-settings up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky
Projects
None yet
Milestone
2.4.1
Development

No branches or pull requests
3 participants
@bclothier @Vogel612 @comintern