Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VersionCheck enhancements #4964

Closed
retailcoder opened this issue May 21, 2019 · 1 comment
Closed

VersionCheck enhancements #4964

retailcoder opened this issue May 21, 2019 · 1 comment
Assignees
@retailcoder
Labels
difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-settings feature-version-check good first issue Want to contribute? That's a good place to start! up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky user-interface This issue explicitly relates to the visible interface of Rubberduck. wpf Issue is easier to resolve with knowledge of WPF/XAML

Comments

@retailcoder
Copy link
Member

Justification
The VersionCheck feature is currently sending an asynchronous HTTP request to http://www.rubberduckvba.com/build/version/stable, which responds with the version number for the latest "green release".

With the website's recent update, that version number is now coming straight from releases, through the GitHub API - rather than returning the assembly version of the Rubberduck.dll assembly depoyed to the website, it's now returning a version number parsed (using a simple regex) from the latest "green release" tag name - which must contain the version number in the format v0.0.0 (or v0.0.0.0).

The website's BuildController has been updated to also provide a response to http://rubberduckvba.com/build/version/prerelease, which yields a version number parsed (using a simple regex) from the latest tag against the [next] branch - the tag name must contain the version number in the format v0.0.0.0 (or v0.0.0).

Description
Let's enhance the VersionCheck settings to offer 3 settings:

  • Check if a new pre-release build is available
  • Check if a new release build is available
  • Don't check if a new version is available at startup

For back-compat, let's treat the existing "Check if a new version is available" setting as "Check if a new release build is available". This enhanced setting would probably look best with a combobox selection (currently a simple checkbox).
@retailcoder retailcoder added enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. user-interface This issue explicitly relates to the visible interface of Rubberduck. feature-settings up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. feature-version-check wpf Issue is easier to resolve with knowledge of WPF/XAML labels May 21, 2019
@Hosch250
Copy link
Member

Hosch250 commented May 21, 2019 •
edited by retailcoder

Radio buttons can work too.

@retailcoder retailcoder added the good first issue Want to contribute? That's a good place to start! label May 21, 2019
@retailcoder retailcoder mentioned this issue Sep 13, 2019
Closed
@retailcoder retailcoder self-assigned this Oct 12, 2019
@retailcoder retailcoder mentioned this issue Oct 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@retailcoder retailcoder

Labels
difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-settings feature-version-check good first issue Want to contribute? That's a good place to start! up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky user-interface This issue explicitly relates to the visible interface of Rubberduck. wpf Issue is easier to resolve with knowledge of WPF/XAML
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@retailcoder @Hosch250