Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "Encapsulate Field" Preview Window Bigger #5200

Closed
ChrisBrackett opened this issue Oct 8, 2019 · 5 comments · Fixed by #5227
Closed

Make the "Encapsulate Field" Preview Window Bigger #5200

ChrisBrackett opened this issue Oct 8, 2019 · 5 comments · Fixed by #5227
Labels
difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. hacktoberfest Tags issues for Hacktoberfest 2019 up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky user-experience Issue relates to user experience (workflow, flexibility, customisation)

Comments

@ChrisBrackett
Copy link

Justification
The "Encapsulate Field" preview window is too small to show a 3 line Get, 3 line Let and 1 line variable declaration. There are no scroll bars on the window so it looks like all visible text is displayed when in fact some of it is hidden

Description
Add scroll bars, and/or make the initial window size bigger : )

Initial View
-It looks like the result will only create a property-get and won't honor the setter type check boxes.
Capture1

Expanded View (after clicking the Expand/Collapse button twice)
-Ah! Now I can see what Rubberduck is going to do and just how awesome it is! Let's make this preview window this size by default.
Capture2

@ChrisBrackett ChrisBrackett added the enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. label Oct 8, 2019
@Vogel612 Vogel612 added difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. hacktoberfest Tags issues for Hacktoberfest 2019 up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky user-experience Issue relates to user experience (workflow, flexibility, customisation) labels Oct 9, 2019
@Vogel612
Copy link
Member

Vogel612 commented Oct 9, 2019

This should be fixable by adjusting some size-related properties on the BindableTextEditor control included in the EncapsulateFieldView.xaml here:

<controls:BindableTextEditor Margin="10,10,10,10"
FontFamily="Courier New "
ShowLineNumbers="False"
HorizontalScrollBarVisibility="Auto"
VerticalScrollBarVisibility="Disabled"
IsReadOnly="True"
Text="{Binding PropertyPreview,Mode=OneWay}"/>

The control exposes all properties that AvalonEdit's TextEditor already exposes, which includes MinHeight and Height both inherited from the Control class. Adding a sensible MinHeight should fix this issue

@retailcoder
Copy link
Member

I agree with the resizing, and I'd say there should be scrollbars if there's more content than what's shown.

@retailcoder
Copy link
Member

Great issue BTW, thanks for opening this!

@ChrisBrackett
Copy link
Author

: )

@IvenBach
Copy link
Member

IvenBach commented Oct 9, 2019

This is a great 01-duckling issue. Vogel's already laid the trail of breadcrumbs out. If you have any more questions :hint: :hint: we're happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. hacktoberfest Tags issues for Hacktoberfest 2019 up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky user-experience Issue relates to user experience (workflow, flexibility, customisation)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants