New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Inspections not highlighting code on double click #5269
Comments
@daFreeMan Is it just flickering because the Code Inspections window is getting focus and not the IDE? I had similar thoughts till I realized which had focus. Clicking the title bar of the IDE to give it focus shows that the correct inspection is selected. |
Yup, you are correct - when I click the IDE title bar, the code does appear highlighted. However, this is new behavior. Previous versions (not sure how previous) would show the code highlighted whether I manually clicked the VBE or not. I suppose they left the VBE as the focused window instead of the CI tool window (which I do not use docked). |
That's a VBIDE quirk, nothing appears to be selected unless the code pane has focus. I don't think this is something we can fix. |
I'd think that is fixable, since it seems to have been broken (recently-ish). This is not something I'd ever had issue with before. I tried using the CI window docked once, hated it and it's been undocked ever since. I know I've used the CI in this fashion before - many times before, and the code's always been highlighted because the VBE has gotten the focus from the tool window after the double-click. I'm not sure how or why it was broken, but it used to work. I'll be happy to go back through my collection of pre-release builds and install & test until I find one that works, if that would help. |
Given that it recently got a horizontal scrollbar, it would be easy to download the version before that merge and see if it behaves or not. |
I’ve noticed this behavior for quite some time. Before the scroll bars for certain. |
Build .4993: Works Looks like 5132 broke things. I'll investigate the 5096->5097->5105 changes and report as a separate issue if necessary |
Probably, the following event handler is to blame. It was introduces to avoid that the event reaches the scroll viewer. However, that seems to also have swallowed the focus change. |
Hi, for me the double click doesn't work for several versions. Today I tried the lastes version and still the double click in Code Inspections doesn't work. Version 2.5.2.5936 |
I have more Infos and a workaround: Hope it helps Version 2.5.2.5984 |
Rubberduck version information
Description
Double clicking an inspection in the
Code Inspections
window causes a very brief flicker of highlight, but leaves the offending code unhighlighted.To Reproduce
Steps to reproduce the behavior:
Expected behavior
This is a regression somewhere along the line. Double-clicking an inspection should leave the impacted code highlighted.
Screenshots
This was recorded in build .5170, but I did test & duplicate in .5182 - I just didn't re-record it.
Logfile
RubberduckLog.txt
Additional context
Loads of inspections in this project... Just confirmed the same behavior in Access. Wasn't there last time I looked at inspections, but that has been a... while...
Additional, additional context
This happens the vast majority of the time, but it's not a 100% failure rate. On occasion, it will leave the code highlighted. It's probably a 95+% failure rate, though.
The text was updated successfully, but these errors were encountered: