BuildController now uses GitHub releases to determine /stable and /pr…

…erelease build versions. Cached for 24 hours.

RubberduckWeb/RubberduckWeb/Controllers/BuildController.cs

@@ -17,7 +17,7 @@ public ActionResult Index()
             return View("Version");
         }
 
-        public ActionResult Version(string id = null)
+        public ActionResult Version(string id)
         {
             var version = string.Empty;
             if (RubberduckReleaseBuilds.ShouldInvalidate)
@@ -26,7 +26,7 @@ public ActionResult Version(string id = null)
                 task.Wait();
             }
 
-            if (string.IsNullOrWhiteSpace(id))
+            if (string.Equals(id, "prerelease", StringComparison.OrdinalIgnoreCase))
             {
                 version = RubberduckReleaseBuilds.LatestPreReleaseVersion.ToString();
             }

RubberduckWeb/RubberduckWeb/Models/RubberduckInspections.cs

@@ -2,52 +2,12 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Net.Http;
-using System.Text.RegularExpressions;
 using System.Threading.Tasks;
 using System.Xml.Linq;
 using Octokit;
 
 namespace RubberduckWeb.Models
 {
-    public static class RubberduckReleaseBuilds
-    {
-        private const string GitHubOrg = "rubberduck-vba";
-        private const string RepositoryName = "Rubberduck";
-
-        private static readonly string VersionPattern = @"v(?<major>\d+)\.(?<minor>\d+)\.(?<revision>\d+)\.(?<build>\d+)";
-
-        private static DateTime _lastInvalalidated;
-
-        public static async Task InvalidateAsync()
-        {
-            var client = new GitHubClient(new ProductHeaderValue("rubberduck-vba_RubberduckWEB"));
-            var releases = await client.Repository.Release.GetAll(GitHubOrg, RepositoryName);
-            var stable = releases.FirstOrDefault(e => !e.Prerelease);
-            var pre = releases.FirstOrDefault(e => e.Prerelease);
-
-            var stableVersion = Regex.Match(stable.Name, VersionPattern);
-            LatestStableVersion = new Version(
-                int.Parse(stableVersion.Groups["major"].Value), 
-                int.Parse(stableVersion.Groups["minor"].Value), 
-                int.Parse(stableVersion.Groups["revision"].Value), 
-                int.Parse(stableVersion.Groups["build"].Value));
-
-            var preVersion = Regex.Match(pre.Name, VersionPattern);
-            LatestPreReleaseVersion = new Version(
-                int.Parse(preVersion.Groups["major"].Value),
-                int.Parse(preVersion.Groups["minor"].Value),
-                int.Parse(preVersion.Groups["revision"].Value),
-                int.Parse(preVersion.Groups["build"].Value));
-
-            _lastInvalalidated = DateTime.UtcNow;
-        }
-
-        public static Version LatestStableVersion { get; private set; }
-        public static Version LatestPreReleaseVersion { get; private set; }
-
-        public static bool ShouldInvalidate => _lastInvalalidated == default(DateTime) || DateTime.UtcNow > _lastInvalalidated.AddDays(1);
-    }
-
     public static class RubberduckInspections
     {
         private const string GitHubOrg = "rubberduck-vba";

RubberduckWeb/RubberduckWeb/Models/RubberduckReleaseBuilds.cs

@@ -0,0 +1,53 @@
+using System;
+using System.Linq;
+using System.Text.RegularExpressions;
+using System.Threading.Tasks;
+using Octokit;
+
+namespace RubberduckWeb.Models
+{
+    public static class RubberduckReleaseBuilds
+    {
+        private const string GitHubOrg = "rubberduck-vba";
+        private const string RepositoryName = "Rubberduck";
+
+        private static readonly string VersionPattern = @"v(?<major>\d+)\.(?<minor>\d+)\.(?<revision>\d+)\.?(?<build>\d+)?";
+
+        public static async Task InvalidateAsync()
+        {
+            var client = new GitHubClient(new ProductHeaderValue("rubberduck-vba_RubberduckWEB"));
+            var releases = await client.Repository.Release.GetAll(GitHubOrg, RepositoryName);
+            var stable = releases.FirstOrDefault(e => !e.Prerelease);
+            if (stable != default(Release))
+            {
+                var stableVersion = Regex.Match(stable.TagName, VersionPattern);
+                LatestStableVersion = new Version(
+                    int.Parse(stableVersion.Groups["major"].Value),
+                    int.Parse(stableVersion.Groups["minor"].Value),
+                    int.Parse(stableVersion.Groups["revision"].Value),
+                    stableVersion.Groups["build"].Success ? int.Parse(stableVersion.Groups["build"].Value) : 0);
+
+                LastInvalidated = DateTime.UtcNow;
+            }
+            var pre = releases.FirstOrDefault(e => e.Prerelease);
+            if (pre != default(Release))
+            {
+                var preVersion = Regex.Match(pre.TagName, VersionPattern);
+                LatestPreReleaseVersion = new Version(
+                    int.Parse(preVersion.Groups["major"].Value),
+                    int.Parse(preVersion.Groups["minor"].Value),
+                    int.Parse(preVersion.Groups["revision"].Value),
+                    preVersion.Groups["build"].Success ? int.Parse(preVersion.Groups["build"].Value) : 0);
+
+                LastInvalidated = DateTime.UtcNow;
+            }
+        }
+
+        public static Version LatestStableVersion { get; private set; }
+        public static Version LatestPreReleaseVersion { get; private set; }
+
+        public static DateTime LastInvalidated { get; private set; }
+
+        public static bool ShouldInvalidate => LastInvalidated == default(DateTime) || DateTime.UtcNow > LastInvalidated.AddDays(1);
+    }
+}

RubberduckWeb/RubberduckWeb/RubberduckWeb.csproj

@@ -242,6 +242,7 @@
     <Compile Include="Models\IndenterSettingsModel.cs" />
     <Compile Include="Models\InspectionInfo.cs" />
     <Compile Include="Models\RubberduckInspections.cs" />
+    <Compile Include="Models\RubberduckReleaseBuilds.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="VBA\FormattedCodeBlockBuilder.cs" />
   </ItemGroup>