Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new option to disable date modification #56

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Add new option to disable date modification #56

merged 1 commit into from
Sep 10, 2023

Conversation

rubegartor
Copy link
Owner

Add new option to disable date modification of output file, preserving the original generation date of the output file.

Described in #54

This improvement will be added in version 1.3.2

@rubegartor rubegartor added the enhancement New feature or request label Sep 5, 2023
@rubegartor rubegartor self-assigned this Sep 5, 2023
Ellingson
Ellingson suggested changes Sep 6, 2023
View reviewed changes
Copy link

@Ellingson Ellingson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend changing constant to fileModifyDatesOption and the config option to fileModifyDates so as to not confuse it with potential future options to copy meta dates. It also falls in line with EXIFTool's naming.

@rubegartor rubegartor force-pushed the modify-dates-option branch 2 times, most recently from 058a73c to ada404a Compare September 6, 2023 14:50
@rubegartor rubegartor marked this pull request as draft September 6, 2023 17:57
@rubegartor rubegartor marked this pull request as ready for review September 10, 2023 13:31
@rubegartor rubegartor merged commit 4a6b352 into master Sep 10, 2023
@rubegartor rubegartor deleted the modify-dates-option branch September 10, 2023 21:30
@rubegartor rubegartor linked an issue Sep 28, 2023 that may be closed by this pull request
Created date of joined video does not match the created date of first video. #54
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ellingson Ellingson Ellingson requested changes

Assignees

@rubegartor rubegartor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Created date of joined video does not match the created date of first video.
2 participants
@rubegartor @Ellingson