Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise file upload in run #403

Open
3 tasks
rubenarslan opened this issue Nov 22, 2018 · 4 comments
Open
3 tasks

Generalise file upload in run #403

rubenarslan opened this issue Nov 22, 2018 · 4 comments
Assignees
Milestone

Comments

@rubenarslan
Copy link
Owner

rubenarslan commented Nov 22, 2018

We need the following changes to the file upload in the run

  • file links should be served via the subdomain of the study now that we have subdomains. old links should hard redirect (to avoid XSS)
  • we can then allow upload of HTML, JS, CSS, PDF files (no worries about cross-site scripting)
  • For people who just want to upload stimulus1 to 50, or people who upload HTML and PDFs, we need to make the file name randomisation optional. It's probably needed less often than normal names are requested.
@rubenarslan
Copy link
Owner Author

this comes up quite often, we mask the file names, but this is really mainly a feature to get anonymity. it isn't always desired and comes at the price of meaningless file names. we also no longer need the long names to prevent conflicts between runs. in the future, files should be accessible under study-name.formr.org/assets/file1.jpg etc unless the automatic masking is desired.

@mpw-wwu
Copy link
Collaborator

mpw-wwu commented Nov 22, 2018

I'm not sure, if this is a good idea. People could easily rip all files from a run. The user/researcher might not always be aware of that. I don't like bossing around the user, but in this case it might make sense.

It's become kind of standard to obfuscate the paths to files nowadays.

@rubenarslan
Copy link
Owner Author

rubenarslan commented Nov 23, 2018 via email

@rubenarslan rubenarslan changed the title Allow sequentially numbered files etc Generalise file upload in run Feb 14, 2019
@rubenarslan rubenarslan added this to the v0.19.0 milestone Feb 14, 2019
@rubenarslan
Copy link
Owner Author

If we implement this, it will be much easier for users to integrate with lab.js and jsPsych.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants