Push notifications #429
Open
Push notifications #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added icon set and manifest.json required for push notifications.
… dispatch push notifications.
mpw-wwu
commented
Oct 22, 2019
| "background_color": "#000000", | ||
| "display": "browser", | ||
| "Scope": "PsyTD/formr-entwicklung", | ||
| "start_url": "https://www.uni-muenster.de/PsyTD/formr-entwicklung", |
There was a problem hiding this comment.
We need to check if we can insert this dynamically.
mpw-wwu
commented
Oct 22, 2019
webroot/sw.js
Outdated
| }); | ||
|
|
||
| if (client !== undefined) { | ||
| client.navigate('https://www.uni-muenster.de/PsyTD/formr-entwicklung/NeuesQueuingSystemTest'); |
There was a problem hiding this comment.
The link to the run needs to be inserted here. Should be part of the push notification.
|
@mpw-wwu Please could you create a new feature branch too called feature/push-notifications under rubenarslan/formr.org ? and let's merge this pull request there? |
|
Sure I can do that. Having a pull request allows us to view the changes easily on here and do reviews on the code as Github provides a nice web ui for that. I'll do some more changes today and push it into the requested feature branch. |
Workaround for this issue: web-push-libs/web-push-php#108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Co-Developers,
this is the push-code that I've written so far. It is basically in working state. But has some issues that need to be addressed.
This pull request is not meant to be merged. It's just a basis for discussion of further steps.
Best,
Matthias