Catch exceptions coming from decrypt() #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A nuber of exceptions may be thrown by various libraries used in decrypt. One especially important one would be that URI.parse functions do not validate a URI, and will raise errors if they get an invalid URI. We should catch the error and provide a sensible return value to allow the user to know that decrypt has failed and why.
|
This should fix those two issues. |
|
I reason about this on issue #4 . So I close this. Many thanks though! |
|
Just released 1.0.2 including fixes for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nuber of exceptions may be thrown by various libraries used in decrypt.
One especially important one would be that URI.parse functions do not
validate a URI, and will raise errors if they get an invalid URI.
We should catch the error and provide a sensible return value to allow
the user to know that decrypt has failed and why.