Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow self hosted gitlab server #13

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

bjelline
Copy link
Contributor

@bjelline bjelline commented Nov 1, 2021

Hello rubenmoya,

I use your package to authenticate with my self hosted gitlab.
To get this to work I had to do only a little modification - maybe you want to merge it?

This pull request adds one line to the configuration:

gitlabUrl: 'https://gitlab.example.com/',

If you don't supply gitlabUrl, https.//www.gitlab.com/ will be used.
So existing installs should not be affected.

This is a minimal pull request, I did not bump the version number in package.json

Copy link
Owner

@rubenmoya rubenmoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

I left a small comment about a typo.

README.md Outdated Show resolved Hide resolved
@rubenmoya rubenmoya merged commit 655d4cf into rubenmoya:main Jan 13, 2022
@rubenmoya
Copy link
Owner

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants