Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridLayoutManager.SpanSizeLookup is not considered #52

Closed
ILAgent opened this issue Nov 2, 2018 · 1 comment

Comments

@ILAgent
Copy link

commented Nov 2, 2018

When we use GridLayoutManager not either element takes 1 cell. That's why logic
if (layoutManager instanceof GridLayoutManager) { offset += ((GridLayoutManager) layoutManager).getSpanCount() - 1; }
is not correct. We need to consider results of spanSizeLookup.getSpanSize

ILAgent added a commit to ILAgent/RecyclerViewSnap that referenced this issue Nov 2, 2018
@rubensousa rubensousa added the bug label Nov 4, 2018
@rubensousa rubensousa added this to the 2.0 milestone Nov 4, 2018
@rubensousa rubensousa self-assigned this Nov 4, 2018
@rubensousa

This comment has been minimized.

Copy link
Owner

commented Nov 11, 2018

Fixed in 2.0

@rubensousa rubensousa closed this Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.