Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test for prefix expansion with other protected contexts #113

Merged
merged 10 commits into from
Oct 13, 2023

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Jul 9, 2023

Regression tests for #112

@jeswr jeswr mentioned this pull request Jul 9, 2023
@jeswr jeswr marked this pull request as draft October 11, 2023 22:02
@jeswr jeswr marked this pull request as ready for review October 12, 2023 15:24
@jeswr
Copy link
Contributor Author

jeswr commented Oct 12, 2023

@rubensworks this is now ready for review

Copy link
Owner

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just two questions regarding possible unneeded changes.

lib/JsonLdParser.ts Outdated Show resolved Hide resolved
lib/ParsingContext.ts Outdated Show resolved Hide resolved
@rubensworks rubensworks merged commit 5a23c1f into rubensworks:master Oct 13, 2023
13 checks passed
@rubensworks
Copy link
Owner

Thanks!

No update for this should be necessary as the dep is just a patch update, but I can publish one if you'd need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants