Fix Quad.equals not checking terms

rubensworks · Aug 31, 2020 · b295f8e · b295f8e
1 parent d7b05c5
commit b295f8e
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/lib/Quad.ts b/lib/Quad.ts
@@ -25,6 +25,10 @@ export class Quad implements RDF.BaseQuad {
   }
 
   public equals(other: RDF.Term | null | undefined): boolean {
-    return !!other && other.termType === 'Quad';
+    return !!other && other.termType === 'Quad' &&
+      this.subject.equals(other.subject) &&
+      this.predicate.equals(other.predicate) &&
+      this.object.equals(other.object) &&
+      this.graph.equals(other.graph);
   }
 }
diff --git a/test/DataFactory-test.ts b/test/DataFactory-test.ts
@@ -245,6 +245,34 @@ describe('DataFactory', () => {
         factory.namedNode('ex:o'),
         factory.namedNode('ex:g'),
       ))).toEqual(true);
+
+      expect(term.equals(factory.quad(
+        factory.namedNode('ex:s-'),
+        factory.namedNode('ex:p'),
+        factory.namedNode('ex:o'),
+        factory.namedNode('ex:g'),
+      ))).toEqual(false);
+
+      expect(term.equals(factory.quad(
+        factory.namedNode('ex:s'),
+        factory.namedNode('ex:p-'),
+        factory.namedNode('ex:o'),
+        factory.namedNode('ex:g'),
+      ))).toEqual(false);
+
+      expect(term.equals(factory.quad(
+        factory.namedNode('ex:s'),
+        factory.namedNode('ex:p'),
+        factory.namedNode('ex:o-'),
+        factory.namedNode('ex:g'),
+      ))).toEqual(false);
+
+      expect(term.equals(factory.quad(
+        factory.namedNode('ex:s'),
+        factory.namedNode('ex:p'),
+        factory.namedNode('ex:o'),
+        factory.namedNode('ex:g-'),
+      ))).toEqual(false);
     });
 
     it('should handle equals for a nested quad', () => {