Use underscore instead of dash in bnode names

This is safer for use in SPARQL queries.
rubensworks · Sep 16, 2020 · c0ffe27 · c0ffe27
1 parent e915423
commit c0ffe27
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/lib/DataFactory.ts b/lib/DataFactory.ts
@@ -29,7 +29,7 @@ export class DataFactory<Q extends RDF.BaseQuad = RDF.Quad> implements RDF.DataF
    * @see BlankNode
    */
   public blankNode(value?: string): BlankNode {
-    return new BlankNode(value || `df-${this.blankNodeCounter++}`);
+    return new BlankNode(value || `df_${this.blankNodeCounter++}`);
   }
 
   /**

diff --git a/test/DataFactory-test.ts b/test/DataFactory-test.ts
@@ -39,17 +39,17 @@ describe('DataFactory', () => {
     });
 
     it('should generate a blank node label without a given label', () => {
-      expect(factory.blankNode().value).toEqual('df-0');
-      expect(factory.blankNode().value).toEqual('df-1');
-      expect(factory.blankNode().value).toEqual('df-2');
+      expect(factory.blankNode().value).toEqual('df_0');
+      expect(factory.blankNode().value).toEqual('df_1');
+      expect(factory.blankNode().value).toEqual('df_2');
     });
 
     it('should generate a blank node label without a given label and consider resets on the factory', () => {
-      expect(factory.blankNode().value).toEqual('df-0');
-      expect(factory.blankNode().value).toEqual('df-1');
+      expect(factory.blankNode().value).toEqual('df_0');
+      expect(factory.blankNode().value).toEqual('df_1');
       factory.resetBlankNodeCounter();
-      expect(factory.blankNode().value).toEqual('df-0');
-      expect(factory.blankNode().value).toEqual('df-1');
+      expect(factory.blankNode().value).toEqual('df_0');
+      expect(factory.blankNode().value).toEqual('df_1');
     });
 
     it('should handle equals', () => {
@@ -111,7 +111,7 @@ describe('DataFactory', () => {
         .equals(factory.literal('a', factory.namedNode('ex:dt')))).toEqual(false);
       expect(factory.literal('a', 'en-us')
         .equals(factory.literal('a',
-          factory.namedNode('http://www.w3.org/1999/02/22-rdf-syntax-ns#langString')))).toEqual(false);
+          factory.namedNode('http://www.w3.org/1999/02/22-rdf_syntax-ns#langString')))).toEqual(false);
 
       expect(factory.literal('a', factory.namedNode('ex:dt'))
         .equals(factory.literal('a'))).toEqual(false);