Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shift size doesn't really matter #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amishas157
Copy link
Contributor

Checked the documentation of Array.shift. Found out that it doesn't really need the size as argument and always gives back the array value at 0th index.

Copy link
Owner

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, you're right.

I would however not remove this size argument, but use the splice function instead. That way, we can still achieve efficient batched stream reading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants