Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert html-entities in msgids to characters #124

Merged
merged 1 commit into from
Dec 14, 2015

Conversation

rubenswieringa
Copy link
Contributor

From PR#166:

tl;dr: angular-gettext-extract extracts … as a html-entity into .po-files, but browsers automatically convert … to .

This means that your translations-file may have a msgid "dots…", but the translate-directive will read "dots…" from a html-element and try to find that as a msgid (and find nothing).

To get around this we convert any … to … when compiling from a .po-file.

We originally solved the above problem for &hellip, but it also applies to certain other HTML-entities. This PR solves the problem on a larger scale.

» Original (longer) explanation of the problem


* HTML-entities tested in the same browsers as PR#116; consistent behavior.

Makes sure that HTML-entities are correctly converted in msgids in .po-files.

This is an addition to the original problem with horizontal ellipsis: rubenv#116
@rubenv
Copy link
Owner

rubenv commented Dec 14, 2015

Excellent pull request (again).

No remarks on this, merging and rolling release.

rubenv added a commit that referenced this pull request Dec 14, 2015
Convert html-entities in msgids to characters
@rubenv rubenv merged commit 379bd77 into rubenv:master Dec 14, 2015
@rubenv
Copy link
Owner

rubenv commented Dec 14, 2015

Published as 2.1.11 for angular-gettext-tools and grunt-angular-gettext.

Thanks a lot!

@rubenswieringa
Copy link
Contributor Author

No problem! Thanks for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants