Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 > Some strings are not translated / noted as Missing #49

Closed
foiseworth opened this issue Mar 17, 2014 · 6 comments
Closed

IE8 > Some strings are not translated / noted as Missing #49

foiseworth opened this issue Mar 17, 2014 · 6 comments

Comments

@foiseworth
Copy link

This is caused by this commit in Angular:
angular/angular.js@37e8b12

Basically, Angular adds a comment which causes the translation not to match.

@rubenv
Copy link
Owner

rubenv commented Mar 17, 2014

Ugh, ugly (good catch though). Can we filter these out?

On Mon, Mar 17, 2014 at 12:39 PM, Andrew notifications@github.com wrote:

This is caused by this commit in Angular:
angular/angular.js@37e8b12angular/angular.js@37e8b12

Basically, Angular adds a comment which causes the
translation not to match.

Reply to this email directly or view it on GitHubhttps://github.com//issues/49
.

@heldrida
Copy link

I'm having the same issue. Is there a way to solve this ?

@rubenv
Copy link
Owner

rubenv commented Apr 30, 2014

It's a guess, but try putting the label in a <span>.

@heldrida
Copy link

@rubenv thanks for looking!

In my specific case, I had stuff like:

<span translate>Foo bar <br>buu yaa</span>

I'm solving this issue by doing:

<span translate>Foo bar buu yaa</span>

I should have used text placeholders instead anyway.

Hope this come useful to someone else in the future.

@maxpeterson
Copy link
Contributor

This looks like it may be the same as #51

maxpeterson added a commit to maxpeterson/angular-gettext that referenced this issue Nov 24, 2014
Related rubenv#49 that is caused by
angular/angular.js/#1949 / angular/angular.js/#2013
maxpeterson added a commit to maxpeterson/angular-gettext that referenced this issue Nov 24, 2014
Related rubenv#49 that is caused by
angular/angular.js/#1949 / angular/angular.js/#2013
@rubenv rubenv modified the milestone: 2.0 Dec 8, 2014
@rubenv
Copy link
Owner

rubenv commented Dec 8, 2014

Should be fixed, credits to @maxpeterson.

@rubenv rubenv closed this as completed Dec 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants