Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice codebase #1

Closed
p0psicles opened this issue Jul 17, 2016 · 5 comments
Closed

Nice codebase #1

p0psicles opened this issue Jul 17, 2016 · 5 comments

Comments

@p0psicles
Copy link
Contributor

Will be watching this! Like your OO approach. Your accepting PR's? On IRC?

@rubenvereecken
Copy link
Owner

rubenvereecken commented Jul 17, 2016

I should get a communication channel, not sure where though. Might go on Slack/Gitter.

Don't have incredible amounts of time to spend on this though. Investigating the proto's that go over the wire is slow-going especially, so I'll probably look out what others can make of it and incorporate into this API. So yes, definitely accepting PRs.

@dmadisetti
Copy link
Collaborator

dmadisetti commented Jul 17, 2016

@rubenvereecken
Copy link
Owner

Looks like I'll visit that channel then. Drop me a line there @p0psicles whenever you want.

@m3talstorm
Copy link

Please follow standard Python naming conventions and format.

@rubenvereecken
Copy link
Owner

@m3talstorm this started out as a Py 3.5 project but I switched because the generated code was crap. But you're right, it's an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants