This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
master|update from main repo #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will freeze all strings so that they are not reallocated each time, for example all of the string values in attr_encrypted_default_options
…l instances of a given class due to shallow dup. This caused random OpenSSL::Cipher::CipherError errors, particularly in cases in which concurrent encrypts/decrypts were occurring.
Rails provides hooks to configure its core classes without loading them: https://api.rubyonrails.org/v5.2.0/classes/ActiveSupport/LazyLoadHooks.html Referencing `ActiveRecord::Base` directly was forcing it to load before the application had finished initializing, which can cause configuration to be applied incorrectly.
Change version to 3.1.0 in Readme
…teral Add frozen_string_literal: true
…en_ssl_cipher_errors Fix random OpenSSL::Cipher::CipherErrors/iv argument errors - Fixes attr-encrypted#306, fixes attr-encrypted#323
Use a lazy load hook to configure Active Record
Fixed a typo in docs
Only load key if needed
Make note about unique key/IV pair more prominent in docs
julitrows
requested review from
paulstuartparker,
hoanewton and
Jagermeister
|
@jantequera https://github.com/ankane/lockbox
|
|
I think we should just come back to the real gem, close this one and make plans to do the database level encryption soon™ |
|
if y'all are interested in maintaining, we can discuss on the linked issue about finding a new maintainer... attr-encrypted#379 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been some updates to the main repo that we could benefit from.
Well, ackchually...
This PR
attr-encrypted#320
Was the one that was left unmerged for so many time that prompted the creation of this fork with the fix. Check Anthony Rocco's comments on the PR. Anthony is a former member of RMD, and the one that built the encryption system in our Rails platform.
I think, if the base gem has the fix already on it, we should
nuke this forkevaluate the discontinuation of this fork and use the base gem.Word of caution, tho: the gem is getting as abandoned as it can be -> attr-encrypted#379