feat: replace VecDeque with Vec since we are not using pop() anymore

rubik · Sep 26, 2020 · 68d7a02 · 68d7a02
1 parent f20cee4
commit 68d7a02
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 15 deletions.
diff --git a/src/orderbook.rs b/src/orderbook.rs
@@ -1,7 +1,7 @@
-use std::collections::{BTreeMap, VecDeque};
+use std::collections::BTreeMap;
 
-use crate::models::{FillMetadata, OrderEvent, OrderType, Side};
 use crate::arena::OrderArena;
+use crate::models::{FillMetadata, OrderEvent, OrderType, Side};
 
 const DEFAULT_MAP_SIZE: usize = 10_000;
 const DEFAULT_QUEUE_SIZE: usize = 10;
@@ -10,8 +10,8 @@ const DEFAULT_QUEUE_SIZE: usize = 10;
 pub struct OrderBook {
     pub min_ask: Option<u64>,
     pub max_bid: Option<u64>,
-    pub asks: BTreeMap<u64, VecDeque<usize>>,
-    pub bids: BTreeMap<u64, VecDeque<usize>>,
+    pub asks: BTreeMap<u64, Vec<usize>>,
+    pub bids: BTreeMap<u64, Vec<usize>>,
     pub arena: OrderArena,
 }
 
@@ -168,9 +168,9 @@ impl OrderBook {
                     self.bids
                         .entry(price)
                         .or_insert_with(|| {
-                            VecDeque::with_capacity(DEFAULT_QUEUE_SIZE)
+                            Vec::with_capacity(DEFAULT_QUEUE_SIZE)
                         })
-                        .push_back(index);
+                        .push(index);
                 }
             }
             Side::Ask => {
@@ -196,9 +196,9 @@ impl OrderBook {
                     self.asks
                         .entry(price)
                         .or_insert_with(|| {
-                            VecDeque::with_capacity(DEFAULT_QUEUE_SIZE)
+                            Vec::with_capacity(DEFAULT_QUEUE_SIZE)
                         })
-                        .push_back(index);
+                        .push(index);
                 }
             }
         }
@@ -304,7 +304,7 @@ impl OrderBook {
 
     fn process_queue(
         arena: &mut OrderArena,
-        opposite_orders: &mut VecDeque<usize>,
+        opposite_orders: &mut Vec<usize>,
         remaining_qty: u64,
         id: u128,
         fills: &mut Vec<FillMetadata>,

diff --git a/tests/orderbook.rs b/tests/orderbook.rs
@@ -1,5 +1,5 @@
 use lobster::{FillMetadata, OrderBook, OrderEvent, OrderType, Side};
-use std::collections::{BTreeMap, VecDeque};
+use std::collections::BTreeMap;
 
 const DEFAULT_QUEUE_SIZE: usize = 10;
 const BID_ASK_COMBINATIONS: [(Side, Side); 2] =
@@ -14,23 +14,23 @@ fn init_ob(events: Vec<OrderType>) -> (OrderBook, Vec<OrderEvent>) {
     (ob, results)
 }
 
-fn init_book(orders: Vec<(u64, usize)>) -> BTreeMap<u64, VecDeque<usize>> {
+fn init_book(orders: Vec<(u64, usize)>) -> BTreeMap<u64, Vec<usize>> {
     let mut bk = BTreeMap::new();
     for (p, i) in orders {
         bk.entry(p)
-            .or_insert_with(|| VecDeque::with_capacity(DEFAULT_QUEUE_SIZE))
-            .push_back(i);
+            .or_insert_with(|| Vec::with_capacity(DEFAULT_QUEUE_SIZE))
+            .push(i);
     }
     bk
 }
 
 fn init_book_holes(
     orders: Vec<(u64, usize)>,
     holes: Vec<u64>,
-) -> BTreeMap<u64, VecDeque<usize>> {
+) -> BTreeMap<u64, Vec<usize>> {
     let mut bk = init_book(orders);
     for h in holes {
-        bk.insert(h, VecDeque::new());
+        bk.insert(h, Vec::new());
     }
     bk
 }