Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for python 3.6 in Code Climate #116

Merged
merged 1 commit into from May 11, 2017
Merged

Adds support for python 3.6 in Code Climate #116

merged 1 commit into from May 11, 2017

Conversation

chrishulton
Copy link
Contributor

Changes

  • Updates codeclimate-radon to not refer to specific python3.x version
  • Will effectively bump python from 3.5.2 to 3.6.1 when incorporated in Code Climate

Details

This should address the string interpolation issue here: #108

Alpine edge now uses python version3.6.1 for the python3 package.
Since the Dockerfile builds from alpine:edge, just rebuilding the docker image will update python to 3.6.1:

(16/16) Installing python3 (3.6.1-r2)

However codeclimate-radon has an explicit reference to python3.5, which doesn't work after the update. I replaced it with the symlinked python3 rather than python3.6 which should be more flexible going forward.

If this looks good, when it's merged I will update Code Climate to reference the commit sha on master. This will incorporate the commits following our last update so it will bring us up to v1.5.0 (plus the few more recent commits).

@coveralls
Copy link

coveralls commented May 10, 2017

Coverage Status

Coverage increased (+0.9%) to 99.284% when pulling 0c3fd65 on chrishulton:cc-bump-python-3.6 into b73c279 on rubik:master.

@rubik
Copy link
Owner

rubik commented May 11, 2017

Thanks a lot for the details as well! 👍

@rubik rubik merged commit d1b1026 into rubik:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants