Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit hook added #36

Merged
merged 1 commit into from
Sep 16, 2020
Merged

pre-commit hook added #36

merged 1 commit into from
Sep 16, 2020

Conversation

lucomsky
Copy link
Contributor

@lucomsky lucomsky commented Aug 5, 2020

Hi! I've added pre-commit hook for Xenon! Check and merge it, please

@rubik
Copy link
Owner

rubik commented Sep 12, 2020

Hi Alexey, thanks for the contribution. I am not sure that this configuration file belongs here. I have no experience with the pre-commit framework, but it seems to me that it's something you would add to your individual repositories, isn't it? Can you elaborate?

@lucomsky
Copy link
Contributor Author

lucomsky commented Sep 15, 2020

Hi, Michele!

One part (.pre-commit-hooks.yaml) should be placed in source repository of pre-commit plugin.

Another part one should place in the root folder of the Python project during develpment.
Here is a part of my example of .pre-commit-config.yaml:

---
repos:
  - repo: https://github.com/lucomsky/xenon.git
    rev: b4898b7
    hooks:
      - id: xenon
        args: [-bB, -mB, -aA]

You can check my pull request:

  1. git init (if you don't have git repository yet in the folder).
  2. pip install pre-commit
  3. pre-commit install
  4. pre-commit run -a xenon

Further info on pre-commit website: https://pre-commit.com/#creating-new-hooks

Kind regards, Alexey.

@rubik
Copy link
Owner

rubik commented Sep 16, 2020

I see. Ok, we can definitely include it. Thanks for your contribution!

@rubik rubik merged commit f5442e9 into rubik:master Sep 16, 2020
davetapley added a commit to davetapley/pre-commit.com that referenced this pull request Apr 6, 2024
@davetapley davetapley mentioned this pull request Apr 6, 2024
4 tasks
davetapley added a commit to davetapley/pre-commit.com that referenced this pull request Apr 6, 2024
@davetapley
Copy link

FYI added to https://pre-commit.com/hooks.html via:
pre-commit/pre-commit.com#949

@rubik maybe include this in README?

repos:
  - repo: https://github.com/lucomsky/xenon.git
    rev: b4898b7
    hooks:
      - id: xenon
        args: [-bB, -mB, -aA]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants