Skip to content

Commit

Permalink
Deprecate #setup, #teardown in specs; use #before, #after.
Browse files Browse the repository at this point in the history
  • Loading branch information
Brian Ford committed Feb 19, 2008
1 parent 6ba4901 commit 91d6c64
Show file tree
Hide file tree
Showing 16 changed files with 22 additions and 23 deletions.
6 changes: 3 additions & 3 deletions spec/README
Expand Up @@ -17,7 +17,6 @@ spec
| +-- breakpoint
| +-- bytearray
| +-- ...
|-- data
|-- kernel
|-- language
|-- library
Expand All @@ -40,8 +39,9 @@ spec
| + -- ...
| + -- time
| + -- yaml
+-- subtend
+-- ext
|-- subtend
| +-- ext
+-- tags

The specs for the reference implementation of the Ruby language (MRI) are
under @spec/ruby@. Presently, these are mostly focused on version 1.8.x and
Expand Down
4 changes: 2 additions & 2 deletions spec/ruby/1.8/core/string/each_line_spec.rb
@@ -1,6 +1,6 @@
require File.dirname(__FILE__) + '/../../spec_helper'
require File.dirname(__FILE__) + '/fixtures/classes.rb'
require File.dirname(__FILE__) + '/shared/each.rb'
require File.dirname(__FILE__) + '/fixtures/classes'
require File.dirname(__FILE__) + '/shared/each'

describe "String#each_line" do
it_behaves_like(:string_each, :each_line)
Expand Down
4 changes: 2 additions & 2 deletions spec/ruby/1.8/core/string/each_spec.rb
@@ -1,6 +1,6 @@
require File.dirname(__FILE__) + '/../../spec_helper'
require File.dirname(__FILE__) + '/fixtures/classes.rb'
require File.dirname(__FILE__) + '/shared/each.rb'
require File.dirname(__FILE__) + '/fixtures/classes'
require File.dirname(__FILE__) + '/shared/each'

describe "String#each" do
it_behaves_like(:string_each, :each)
Expand Down
2 changes: 1 addition & 1 deletion spec/ruby/1.8/core/thread/key_spec.rb
Expand Up @@ -2,7 +2,7 @@
require File.dirname(__FILE__) + '/fixtures/classes'

describe "Thread#key?" do
setup do
before :each do
@th = Thread.new do
Thread.current[:oliver] = "a"
end
Expand Down
5 changes: 2 additions & 3 deletions spec/ruby/1.8/library/erb/filename_spec.rb
Expand Up @@ -3,7 +3,7 @@

describe "ERB#filename" do
# TODO: why does this fail on rubinius?
it "raises is reported when error raised" do
it "raises an exception if there are errors processing content" do
filename = 'foobar.rhtml'
erb = ERB.new('<% if true %>') # will raise SyntaxError
erb.filename = filename
Expand All @@ -29,7 +29,7 @@
end

# TODO: why does this fail on rubinius?
it "use '(erb)' as filename when filename is not set" do
it "uses '(erb)' as filename when filename is not set" do
erb = ERB.new('<% if true %>') # will raise SyntaxError
lambda {
begin
Expand All @@ -52,4 +52,3 @@
end
end
end
fails:ERB#filename uses '(erb)' as filename when filename is not set
2 changes: 1 addition & 1 deletion spec/subtend/array_spec.rb
Expand Up @@ -5,7 +5,7 @@
require File.dirname(__FILE__) + '/ext/subtend_array'

describe "SubtendArray" do
setup do
before :each do
@s = SubtendArray.new
end

Expand Down
2 changes: 1 addition & 1 deletion spec/subtend/class_spec.rb
Expand Up @@ -19,7 +19,7 @@ def initialize(v)
end

describe "SubtendClass" do
setup do
before :each do
@s = SubtendClass.new
end

Expand Down
4 changes: 2 additions & 2 deletions spec/subtend/define_method_vis_spec.rb
Expand Up @@ -18,7 +18,7 @@ def test_s
end

describe "SubtendMethodVisModule" do
setup do
before :each do
@c = SubtendMethodVisModuleTest.new
end

Expand All @@ -39,7 +39,7 @@ def test_s
end

describe "SubtendMethodVis" do
setup do
before :each do
@c = SubtendMethodVis.new
end

Expand Down
2 changes: 1 addition & 1 deletion spec/subtend/exception_spec.rb
Expand Up @@ -5,7 +5,7 @@
require File.dirname(__FILE__) + '/ext/subtend_exception'

describe "SubtendRaiser" do
setup do
before :each do
@s = SubtendRaiser.new
end

Expand Down
2 changes: 1 addition & 1 deletion spec/subtend/float_spec.rb
Expand Up @@ -5,7 +5,7 @@
require File.dirname(__FILE__) + '/ext/subtend_float'

describe "SubtendFloat" do
setup do
before :each do
@f = SubtendFloat.new
end

Expand Down
2 changes: 1 addition & 1 deletion spec/subtend/hash_spec.rb
Expand Up @@ -5,7 +5,7 @@
require File.dirname(__FILE__) + '/ext/subtend_hash'

describe "SubtendHash" do
setup do
before :each do
@s = SubtendHash.new
end

Expand Down
2 changes: 1 addition & 1 deletion spec/subtend/module_spec.rb
Expand Up @@ -10,7 +10,7 @@ module SubtendModuleTest
BAR = 7
end

setup do
before :each do
@m = SubtendModule.new
end

Expand Down
2 changes: 1 addition & 1 deletion spec/subtend/object_spec.rb
Expand Up @@ -6,7 +6,7 @@

describe "SubtendObject" do

setup do
before do
@o = SubtendObject.new
end

Expand Down
2 changes: 1 addition & 1 deletion spec/subtend/string_spec.rb
Expand Up @@ -5,7 +5,7 @@
require File.dirname(__FILE__) + '/ext/subtend_string'

describe "SubtendString" do
setup do
before :each do
@s = SubtendString.new
end

Expand Down
2 changes: 1 addition & 1 deletion spec/subtend/wrapped_struct_spec.rb
Expand Up @@ -5,7 +5,7 @@
require File.dirname(__FILE__) + '/ext/subtend_wrapped_struct'

describe "SubtendWrappedStruct" do
setup do
before :each do
@s = SubtendWrappedStruct.new
end

Expand Down
2 changes: 1 addition & 1 deletion spec/tags/ruby/1.8/core/kernel/load_tags.txt
@@ -1 +1 @@
Kernel#load allows wrapping the code in the file in an anonymous module
fails:Kernel#load allows wrapping the code in the file in an anonymous module

0 comments on commit 91d6c64

Please sign in to comment.