Changed Enumerable#inject, Enumerator#each_with_index and Enumerator#with_index to use Rubinius.single_block_arg, which should fix #1457 #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulled in the optimization from Integer#round for ndigits < 0 and an optimization from MRI's numeric.c flo_round for large exponents. Thanks @brixen!
NAN & non-positive precision raises a RangeErrorm not a FloatDomainError.
…or#with_index calls together
…_spec.rb to new /enumerator/inject_spec.rb
…with_index to use Rubinius.single_block_arg, which should fix #1457
|
Ok. I've messed this pull request up somehow by including commits from @jc00ke If anyone can tell me the quickest way to fix, that would be appreciated. |
|
I suppose you could interactively rebase your commits into one chunk after my cbc285a & then re-open. That might work. |
|
Closing. Opening new pull request with my changes rebased into a single commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.9 mode, if each_with_index was followed by inject or by each_with_index again, it gave a different answer from MRI 1.9 and from 1.8 in MRI and Rubinius. Reported as issue #1457.
To fix this, I changed Enumerable#inject, Enumerator#each_with_index and Enumerator#with_index to use:
I hope that was the right thing to do. It seems to fix the problem without causing any other spec failures.
I wasn't quite clear how to structure the specs.
Advice appreciated.
Thanks
Tom