assert regexp equality by content not pointer #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
added a commit
that referenced
this pull request
Feb 14, 2012
assert regexp equality by content not pointer
|
Thank you for merging my commit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Regexp::initializecopies a patternStringobject to support encoding in 1.9 mode. Yet, some tests invm:testwrongly assert that the patten obtained fromRegexp::sourceis equal to the passed pattern pointer-wise.For 1.8 mode, this assertion is fine, because a pattern is passed by reference (pointer). For 1.9 mode, this isn't, because it is passed by value (by means of
String::string_dup).In this commit, I changed to always assert by content not by pointer to correctly test regardless of 1.8 or 1.9.