Call llvm_shutdown() #1577
Call llvm_shutdown() #1577
Conversation
|
There's is also Environment::halt_and_exit that probably also needs a similar change. This is used when another thread than the main thread exits. |
|
Thank you for your suggestion! I'm currently trying to address it. On the course of it, I found a bug in my modification. The above commits are for that.. Sorry.. |
|
I made llvm_shutdown() be called from Environment::halt_and_exit, too! |
| env.load_conf(path); | ||
| int exit_code = 0; | ||
|
|
||
| { |
There was a problem hiding this comment.
Any reason for this additional indentation?
There was a problem hiding this comment.
It's for destructing env before calling llvm_shutdown().
Rubinius SEGV-ed without this indentation when exiting with unusual conditions (interrupt by Ctrl-C from the console). So I guessed Environment destructor is touching llvm objects/functions after llvm_shutdown() is called.
For example, without this indentation, I couldn't clean-build rubinius.
Should I explicitly mention this indentation purpose? Or, Should I put the whole indented code into another function? Is it better?
Thanks for reviewing!
There was a problem hiding this comment.
Ah, that's a good one :). A comment to describe this case is probably fine for now, so we know why it's there.
There was a problem hiding this comment.
Hehe. Thanks! I'll push a commit to add that comment shortly!
|
As I said I added a comment to the explicit indentation! |
|
Thanks a lot :) |
According to LLVM docs(http://llvm.org/docs/ProgrammersManual.html#shutdown), calling
llvm::llvm_shutdown()after use of LLVM is advised to prevent memory leaks.Thus, rubinius should call
llvm_shutdown()immediately before exiting frommain()in the CLI driver.