New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding first draft of contributing guidelines #1912
Conversation
Github just pushed the contributing guidelines feature: https://github.com/blog/1184-contributing-guidelines
Ok, few initial thoughts:
|
To respond to the last bullet point from dbussink, generally the first line in Git should not be more than 50 characters. Here is some general advice on Git commit messages: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html |
I prefer @tpope's method. |
@@ -0,0 +1,37 @@ | |||
# Thanks! | |||
|
|||
We want to start off by saying thank you for using Rubinius. This project is a labor of love, and we appreciate all of the users that catch bugs, make performance improvements, and help with documentation. Every contribution is meaningful, so thank you for participating. That being said, here are a few guidelines that we ask you to follow so we can successfully address your issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we break this line up into multiple lines? (e.g: a paragraph split by newlines).
On smaller screens this forces horizontal scrolling, which sucks :P
Since this branch was public I took the liberty of splitting the long lines. @jc00ke |
Nope, I don't mind at all! When I was typing that line out it felt long, but I wasn't sure if it would wrap or scroll on GH. I think this is a good start. I'll merge now, and we can change if needed. |
Adding first draft of contributing guidelines
Github just pushed the contributing guidelines feature:
https://github.com/blog/1184-contributing-guidelines
@brixen @dbussink @evanphx thoughts?