Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IO.copy_stream from a pipe IO instance. #2114

Merged
merged 6 commits into from Feb 4, 2013
Merged

Support IO.copy_stream from a pipe IO instance. #2114

merged 6 commits into from Feb 4, 2013

Commits on Jan 3, 2013

  1. Support IO.copy_stream from a pipe IO instance. 

    IO.copy_stream fails when the IO instance is backed by a pipe, as seek is not
supported on the underlying pipe.

This change required some modification to the copy_stream_spec, I'm open to
suggestions if there's a more preferred way of structuring the spec.
    @warrenseen
    warrenseen committed Jan 3, 2013
    Copy the full SHA
    b717b95 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2013

  1. Merge branch 'master' into IO.copy_stream-from-pipe-patch

    @warrenseen
    warrenseen committed Jan 13, 2013
    Copy the full SHA
    a90c6d7 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2013

  1. Add pipe flag to IO. 

    Add a pipe flag to IO class so we can avoid calling #seek on the source IO in copy_stream.
    @warrenseen
    warrenseen committed Jan 29, 2013
    Copy the full SHA
    2c7a44b View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2013

  1. IO#pipe? shouldn't ever need to fall back to calling Stat#pipe?

    @warrenseen
    warrenseen committed Feb 3, 2013
    Copy the full SHA
    f2a2abb View commit details
    Browse the repository at this point in the history

  2. Add comment explaining the pipe_fixture helper method.

    @warrenseen
    warrenseen committed Feb 3, 2013
    Copy the full SHA
    a894f0b View commit details
    Browse the repository at this point in the history

  3. Change spec to use new_io helper rather than explicitly open files.

    @warrenseen
    warrenseen committed Feb 3, 2013
    Copy the full SHA
    36dc79f View commit details
    Browse the repository at this point in the history