Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for String#scrub #2912

Merged
merged 2 commits into from Mar 10, 2014
Merged

Support for String#scrub #2912

merged 2 commits into from Mar 10, 2014

Commits on Mar 7, 2014

  1. Experimental String#scrub with Encoding::Converter 

    Massive thanks to @headius for coming up with the idea of using
Encoding::Converter and providing a proof of concept. I mainly adapted this for
Rbx with some minor changes.

Note that this particular implementation is *really* slow compared to MRI, it
is however faster than the String#chars version used before. Although I'd
prefer not to we might want to move this over to C++ land if high performance
is required.
    Yorick Peterse committed Mar 7, 2014
    Copy the full SHA
    e467bb8 View commit details
    Browse the repository at this point in the history

  2. Added specs for String#scrub.

    Yorick Peterse committed Mar 7, 2014
    Copy the full SHA
    c0ae661 View commit details
    Browse the repository at this point in the history