Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compat] edible items show AppleSkin food values while disabled #19

Closed
supersaiyansubtlety opened this issue May 8, 2021 · 2 comments
Closed
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@supersaiyansubtlety
Copy link

AppleSkin displays food values for gold ingots, netherite scraps, slime balls, and magma cream, regardless of whether or not those items' /carpet edibleX rules are true.

@RubixDev
Copy link
Owner

Similar to #18 I already noticed this during testing, but didn't think much of it. I believe it has something to do with how I toggle them being edible, as I just add them as food items regardless of them being enabled, but then catch and cancel the eating action when the corresponding rule is disabled. I know this isn't a great solution, but the only one I could think of. I will try to come up with a fix in the next few days.

@RubixDev RubixDev added the bug Something isn't working label May 24, 2021
@RubixDev RubixDev mentioned this issue May 24, 2021
@RubixDev
Copy link
Owner

Sadly i wasn't able to get it to work. I tried fully setting the items to be edible and non-edible every time a rule is toggled and then reloading the server, however it appears such a resource reload doesn't reload the items and such the whole server would have to be restarted every time. I don't think it's too annoying though, as it only affects the players with Carpet, AppleSkin and Rug on their client anyways.

@RubixDev RubixDev added the wontfix This will not be worked on label May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants