Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One potential item for the cop #4

Closed
pravi opened this issue Aug 25, 2020 · 4 comments
Closed

One potential item for the cop #4

pravi opened this issue Aug 25, 2020 · 4 comments

Comments

@pravi
Copy link
Collaborator

pravi commented Aug 25, 2020

The right solution may be in gem2deb-test-runner, but I want to share the issue here.

When autopkgtest is run, lib directory is renamed to force loading the library from system path as installed by the .deb package. But this means bundler cannot find the library if Gemfile references gemspec.

Current work around,
https://salsa.debian.org/ruby-team/ruby-combustion/-/blob/master/debian/patches/adjust-Gemfile.patch

Best solution may be for gem2deb-test-runner to modify Gemfile to replace gemspec with the gem name.

@pravi
Copy link
Collaborator Author

pravi commented Aug 25, 2020

@pravi
Copy link
Collaborator Author

pravi commented Aug 25, 2020

ruby-ahoy-email and ruby-sping also affected. Many others might be affected as well, because we were not able to successfully enable tests when the tests used a dummy rails app and bundler.

Update: ruby-invisible-captcha is another package affected by this issue.

@terceiro
Copy link

terceiro commented Oct 2, 2020

I don't think this is something that rubocop-packaging can do much about.

for example I looked into puma_worker_killer, and 1the problem is that the tests are explicitly using bundler, and we already know that this is a problem, and there is no single way of fixing this for all packages.

@utkarsh2102
Copy link
Member

As discussed, this isn't a candidate for rubocop-packaging to handle. So closing this.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants