Make Node#condition? aware of case-match node
#227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes `Node#condition?` aware of `case-match` node.
|
@marcandre Can you review this PR? jruby-head CI matrix is failing, but it is unrelated to this change. |
|
Thanks @koic, released in v1.17.0 👍 |
|
Thank you! |
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Apr 9, 2022
This PR fixes the following false positive for `Style/DoubleNegation`
when inside returned conditional clauses with Ruby 2.7's pattern matching.
The following is a reproduction case.
```ruby
def foo?
case condition
in foo
!!foo
in bar
!!bar
else
!!baz
end
end
```
It is expected that an offense will not be registered, but in actually
an offense will be registered.
```console
% bundle exec rubocop --only Style/DoubleNegation
(snip)
Inspecting 2 files
C.
Offenses:
example.rb:4:5: C: [Correctable] Style/DoubleNegation: Avoid the use of double negation (!!).
!!foo
^
example.rb:6:5: C: [Correctable] Style/DoubleNegation: Avoid the use of double negation (!!).
!!bar
^
2 files inspected, 2 offenses detected, 2 offenses auto-correctable
```
This is a follow-up to the same issue as rubocop#10474 and requires RuboCop AST 1.7 to fix.
Therefore it bumps RuboCop AST required to use rubocop/rubocop-ast#227
to 1.7 or higher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Node#condition?aware ofcase-matchnode.