Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodePattern: Allow full expressions as function arguments #63

Merged
merged 1 commit into from Jul 13, 2020

Conversation

@marcandre
Copy link
Contributor

@marcandre marcandre commented Jul 11, 2020

No description provided.

@marcandre marcandre force-pushed the marcandre:node_pattern_arg branch from cf4009e to 18722da Jul 11, 2020
@marcandre marcandre mentioned this pull request Jul 11, 2020
@marcandre marcandre force-pushed the marcandre:node_pattern_arg branch 2 times, most recently from 719f5d1 to bd3102c Jul 11, 2020
@@ -316,6 +316,30 @@ We can use the `#prime?` method directly in the expression:
(int #prime?)
----

== Arguments for predicate and external methods

This comment has been minimized.

@bbatsov

bbatsov Jul 12, 2020
Contributor

predicates and external methods? I'm confused by this terminology. :-)

This comment has been minimized.

@marcandre

marcandre Jul 12, 2020
Author Contributor

Right, I'll replace "external methods" with "funcall", which is what is used elsewhere (predicate?, #funcall)

@bbatsov
Copy link
Contributor

@bbatsov bbatsov commented Jul 12, 2020

Looks cool to me. I only find the terminology confusing - e.g. what's special about predicate methods.

@marcandre marcandre force-pushed the marcandre:node_pattern_arg branch from bd3102c to 2a3b8ba Jul 12, 2020
@marcandre marcandre force-pushed the marcandre:node_pattern_arg branch from 2a3b8ba to 84f1a54 Jul 12, 2020
@marcandre marcandre merged commit f93da20 into rubocop-hq:master Jul 13, 2020
14 checks passed
14 checks passed
AST | master | 2.4 (ubuntu)
Details
AST | master | 2.5 (ubuntu)
Details
AST | master | 2.6 (ubuntu)
Details
AST | master | 2.7 (ubuntu)
Details
AST | master | head (ubuntu)
Details
AST | master | mingw (windows)
Details
AST | 0.84.0 | 2.4 (ubuntu)
Details
AST | 0.84.0 | head (ubuntu)
Details
Cov | 0.84.0 | 2.4 (ubuntu)
Details
Modern | master | 2.7 (ubuntu)
Details
Main | 0.84.0 | 2.4 (ubuntu)
Details
Main | master | 2.4 (ubuntu)
Details
Main | 0.84.0 | 2.7 (ubuntu)
Details
Main | master | 2.7 (ubuntu)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.