Remove RetryNode.
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
force-pushed
the
dont_retry
branch
4 times, most recently
from
703c52c
to
28ec9c2
Compare
This node was severely broken, e.g. `#arguments?` raised a `NoMethodError`. I find it has nothing to do with a `MethodDispatchMethod` (since it doesn't call a method), nor a `ParameterizedNode` (since it accepts no argument); best remove the specialized node class altogether.
|
See #71 for discussion if it would be useful to have |
bbatsov
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This node was severely broken, e.g.
#arguments?raised aNoMethodError.I find it has nothing to do with a
MethodDispatchMethod(since itdoesn't call a method), nor a
ParameterizedNode(since it accepts noargument); best remove the node altogether.