Add cop to enforce refute_includes over refute(collection.include?(actual)) #15
Conversation
abhaynikam
force-pushed
the
add-style-guide-for-refute-includes
branch
2 times, most recently
from
1fb6b7b
to
25f116b
Compare
|
Not sure why CI fails. It passes on my local. I did run the documentation command before pushing. can anyone please help me with it? |
|
This repository allow ruby-head to fail. There is no problem if other matrices are successful. |
| assert_offense(<<~RUBY, @cop) | ||
| class FooTest < Minitest::Test | ||
| def test_do_something | ||
| refute(collection.includes?(actual)) |
There was a problem hiding this comment.
Please check against include method instead of includes method.
rubocop/minitest-style-guide#17
There was a problem hiding this comment.
@koic : Resolved the typo and squashed my commits. Please have a look.
abhaynikam
force-pushed
the
add-style-guide-for-refute-includes
branch
2 times, most recently
from
d4f63e3
to
16ba08e
Compare
abhaynikam
changed the title
|
This PR has conflicts. Can you rebase with the latest master branch? |
abhaynikam
force-pushed
the
add-style-guide-for-refute-includes
branch
from
16ba08e
to
a5f5f25
Compare
|
@koic : Resolved merge conflict. Please have a look. |
| module RuboCop | ||
| module Cop | ||
| module Minitest | ||
| # Check if your test uses `refute_includes` |
There was a problem hiding this comment.
I think this is worded confusingly as now it implies that refutes_includes is what's bad.
| RUBY | ||
| end | ||
|
|
||
| def test_registers_offense_when_using_refute_with_include_and_variable_message |
There was a problem hiding this comment.
Same as with the other PR - I don't see a point in having separate tests for a variable message and a constant message. Relying on the param count should be enough here.
abhaynikam
force-pushed
the
add-style-guide-for-refute-includes
branch
from
a5f5f25
to
0d0db24
Compare
|
@bbatsov : Resolved both the comments. Can you please have a look? |
| RUBY | ||
| end | ||
|
|
||
| def test_registers_offense_when_using_refute_with_include_and_constant_message |
There was a problem hiding this comment.
There's still this pointless test with a constant message.
There was a problem hiding this comment.
Oh. My bad. Removing it now.
| # | ||
| # @example | ||
| # # bad | ||
| # refute(collection.include?(actual)) |
There was a problem hiding this comment.
Use object instead of actual everywhere in the test.
…ctual)) trigger CI
abhaynikam
force-pushed
the
add-style-guide-for-refute-includes
branch
from
0d0db24
to
9ab99d6
Compare
|
@bbatsov : Resolve the comments. |
|
Looks good. Thanks! |
PR adds cops to enforce the use of refute_includes over refute(collection.includes?(actual))
Ref: https://github.com/rubocop-hq/minitest-style-guide#refute-includes