Add cop to enfore refute_empty over refute(actual.empty?) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhaynikam
force-pushed
the
add-cop-for-refute-empty-1
branch
from
1e2fefd
to
870b213
Compare
abhaynikam
force-pushed
the
add-cop-for-refute-empty-1
branch
from
870b213
to
5efaffd
Compare
bbatsov
reviewed
Oct 5, 2019
| RUBY | ||
| end | ||
|
|
||
| def test_registers_offense_when_using_refute_with_empty_and_variable_message |
There was a problem hiding this comment.
Aren't tests with variable/constant message redundant? The way I see it you only check for the argument count in the cop itself, so this is bound to work whatever you pass to it.
bbatsov
reviewed
Oct 5, 2019
| module RuboCop | ||
| module Cop | ||
| module Minitest | ||
| # Check if your test uses `refute_empty` instead of `refute(actual.empty?)`. |
There was a problem hiding this comment.
I think you meant to write this the other way around.
abhaynikam
force-pushed
the
add-cop-for-refute-empty-1
branch
from
5efaffd
to
e906b85
Compare
|
@bbatsov : Resolved the comments on this PR too. Please have a look. |
bbatsov
reviewed
Oct 7, 2019
| module Cop | ||
| module Minitest | ||
| # This cop enforces to use `refute_empty` instead of | ||
| # using `refute(actual.empty?)`. |
bbatsov
reviewed
Oct 7, 2019
| RUBY | ||
| end | ||
|
|
||
| def test_registers_offense_when_using_refute_with_empty_and_string_message |
There was a problem hiding this comment.
I guess "string message" can be shortened to just "message".
abhaynikam
force-pushed
the
add-cop-for-refute-empty-1
branch
from
e906b85
to
9518f36
Compare
abhaynikam
force-pushed
the
add-cop-for-refute-empty-1
branch
from
9518f36
to
43488d1
Compare
|
@bbatsov : Rebased and resolved the comments. Please have a look. Thanks |
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds cops to enforce the use of refute_empty over refute(actual.empty?)
Ref: https://github.com/rubocop-hq/minitest-style-guide#refute-empty