Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minitest/AssertEqual #31

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Minitest/AssertEqual #31

merged 1 commit into from
Oct 16, 2019

Conversation

herwinw
Copy link
Contributor

@herwinw herwinw commented Oct 15, 2019

Prefer assert_equal over assert(expected == actual)
(I'll leave the updates to the changelog until the merge of #29, to save myself some merge conflicts. The remainder of the code can be reviewed)


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

config/default.yml Outdated Show resolved Hide resolved
@abhaynikam
Copy link
Contributor

@herwinw This PR would also need a changelog entry. Rest LGTM 🎉

@bbatsov
Copy link
Contributor

bbatsov commented Oct 16, 2019

Apart from the small remark I made the cop looks ok to me. You can add a changelog entry now.

@herwinw herwinw force-pushed the assert_equal branch 2 times, most recently from ab76ab8 to fa957b7 Compare October 16, 2019 07:00
@herwinw
Copy link
Contributor Author

herwinw commented Oct 16, 2019

Fixed all the remarks, should be ready to merge

@bbatsov bbatsov merged commit 38d6638 into rubocop:master Oct 16, 2019
@bbatsov
Copy link
Contributor

bbatsov commented Oct 16, 2019

Thanks!

@herwinw herwinw deleted the assert_equal branch October 16, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants