Mark Performance/AncestorsInclude as unsafe #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't tell whether the receiver is a class or an object.
|
Thanks! |
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
Aug 26, 2020
…ude` Fixes rubocop#159. This PR fixes a false positive for `Performance/AncestorsInclude` when receiver is a variable. As the cop's example shows, this change mainly targets when the receiver is a constant. It can cause false negatives, but it may be less than false positives. And this change may lead to removing unsafe marked by rubocop#149.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't tell whether the receiver is a class or an object.
In my particular case, the false positive was for
Nokogiri::XML::Node#ancestors:https://github.com/sparklemotion/nokogiri/blob/v1.10.10/lib/nokogiri/xml/node.rb#L601
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.