Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto-correction for Performance/Caller #189

Merged

Conversation

koic
Copy link
Member

@koic koic commented Nov 7, 2020

This PR supports auto-correction for Performance/Caller.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR supports auto-correction for `Performance/Caller`.
@koic koic changed the title Support autocorrect for Performance/Caller Support auto-correction for Performance/Caller Nov 7, 2020
@koic koic force-pushed the support_autocorrect_for_performance_caller branch from a1b7d22 to eccc62a Compare November 7, 2020 18:21
@koic koic merged commit 392ac0c into rubocop:master Nov 9, 2020
@koic koic deleted the support_autocorrect_for_performance_caller branch November 9, 2020 02:24
@IsaacDempsey
Copy link

Why is this best practice? Can't find any documentation on this.

@marcandre
Copy link
Contributor

Why is this best practice? Can't find any documentation on this.

It requests only the single stack frame desired instead of requesting the full stack trace and throwing away all but one element. Thus much faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants