Merge pull request #358 from koic/fix_false_positive_for_rails_revers…

…ible_migration

[Fix #357] Fix a false positive for `Rails/ReversibleMigration`

CHANGELOG.md

@@ -10,6 +10,7 @@
 * [#351](https://github.com/rubocop-hq/rubocop-rails/pull/351): Add `<>` operator to `Rails/WhereNot` cop. ([@Tietew][])
 * [#352](https://github.com/rubocop-hq/rubocop-rails/pull/352): Do not register offense if given a splatted hash. ([@dvandersluis][])
 * [#346](https://github.com/rubocop-hq/rubocop-rails/pull/346): Fix a false positive for `Rails/DynamicFindBy` when any of the arguments are splat argument. ([@koic][])
+* [#357](https://github.com/rubocop-hq/rubocop-rails/issues/357): Fix a false positive for `Rails/ReversibleMigration` when keyword arguments of `change_column_default` are in the order of `to`, `from`. ([@koic][])
 
 ## 2.8.0 (2020-09-04)
 

lib/rubocop/cop/rails/reversible_migration.rb

@@ -360,7 +360,7 @@ def all_hash_key?(args, *keys)
             key.children.first.to_sym
           end
 
-          hash_keys & keys == keys
+          (hash_keys & keys).sort == keys
         end
       end
     end

spec/rubocop/cop/rails/reversible_migration_spec.rb

@@ -114,6 +114,11 @@ def change
       change_column_default(:posts, :state, from: nil, to: "draft")
     RUBY
 
+    it_behaves_like 'accepts',
+                    'change_column_default(with :to and :from)', <<-RUBY
+      change_column_default(:posts, :state, to: "draft", from: nil)
+    RUBY
+
     it_behaves_like 'accepts',
                     'change_column_default(*column :from and :to)', <<-RUBY
       columns = [:foo, :bar]