Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails/NegateInclude is not safe for auto correction #384

Closed
adamcooke opened this issue Nov 16, 2020 · 2 comments · Fixed by #385
Closed

Rails/NegateInclude is not safe for auto correction #384

adamcooke opened this issue Nov 16, 2020 · 2 comments · Fixed by #385
Labels
bug Something isn't working

Comments

@adamcooke
Copy link

We cannot assume that everything that implements include? also implements exclude?. While Rails does add this to some things, it doesn't add them to everything and making this assumption is dangerous.

For example, IPAddr (in stdlib) has an include? method but does not have an exclude?.

Expected behaviour

Inserting !something.include?(x) should not correct to something.exclude?(x).

Actual behavior

It was corrected.

RuboCop version

$ [bundle exec] rubocop -V
1.3.0
koic added a commit to koic/rubocop-rails that referenced this issue Nov 18, 2020
@koic
[Fix rubocop#384] Mark unsafe for Rails/NegateInclude
b97526b
@koic koic added the bug Something isn't working label Nov 18, 2020
koic added a commit to koic/rubocop-rails that referenced this issue Nov 18, 2020
@koic
[Fix rubocop#384] Mark unsafe for Rails/NegateInclude
9e4f71c 
Fixes rubocop#384

This PR marks unsafe for `Rails/NegateInclude` because false positive
will occurs for a receiver object that do not have `exclude?` method.
(e.g. `IPAddr`)
koic added a commit to koic/rubocop-rails that referenced this issue Nov 18, 2020
@koic
[Fix rubocop#384] Mark unsafe for Rails/NegateInclude
b45f1f3 
Fixes rubocop#384

This PR marks unsafe for `Rails/NegateInclude` because false positive
will occurs for a receiver object that do not have `exclude?` method.
(e.g. `IPAddr`)
@koic koic mentioned this issue Nov 18, 2020
Merged
9 tasks
koic added a commit to koic/rubocop-rails that referenced this issue Nov 18, 2020
@koic
[Fix rubocop#384] Mark unsafe for Rails/NegateInclude
b024858 
Fixes rubocop#384

This PR marks unsafe for `Rails/NegateInclude` because false positive
will occur for a receiver object that do not have `exclude?` method.
(e.g. `IPAddr`)
@koic koic closed this as completed in #385 Nov 18, 2020
koic added a commit that referenced this issue Nov 18, 2020
@koic
Merge pull request #385 from koic/mark_unsafe_for_rails_negate_include
377195b 
[Fix #384] Mark unsafe for `Rails/NegateInclude`
@adamcooke
Copy link
Author

Thank you!

@koic
Copy link
Member

koic commented Nov 18, 2020

@adamcooke You are welcome. Thank you for the feedback!

koic added a commit to koic/rubocop-rails that referenced this issue Nov 20, 2020
@koic
[Fix rubocop#384] Mark unsafe for Rails/NegateInclude
50bbea9 
Fixes rubocop#384

This PR marks unsafe for `Rails/NegateInclude` because false positive
will occur for a receiver object that do not have `exclude?` method.
(e.g. `IPAddr`)
@dependabot dependabot bot mentioned this issue Mar 18, 2021
Closed
@eneagoe eneagoe mentioned this issue Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #384] Mark unsafe for Rails/NegateInclude koic/rubocop-rails
2 participants
@adamcooke @koic