Skip to content

Commit

Permalink
Merge pull request #901 from rubocop-hq/drop-support-for-ruby-2.3
Browse files Browse the repository at this point in the history
Drop support for Ruby 2.3
  • Loading branch information
bquorning committed Apr 27, 2020
2 parents dff8957 + 3038e0f commit cd6bc33
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 16 deletions.
14 changes: 0 additions & 14 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,6 @@ jobs:
- run: bundle install
- run: rake confirm_config documentation_syntax_check confirm_documentation

# Ruby 2.3
ruby-2.3-rspec:
docker:
- image: circleci/ruby:2.3
<<: *rspec
ruby-2.3-rubocop:
docker:
- image: circleci/ruby:2.3
<<: *rubocop

# Ruby 2.4
ruby-2.4-rspec:
docker:
Expand Down Expand Up @@ -128,10 +118,6 @@ workflows:
- confirm_config_and_documentation

# Use `requires: [confirm_config_and_documentation]` to trick Circle CI into starting the slow jruby job early.
- ruby-2.3-rspec:
requires: [confirm_config_and_documentation]
- ruby-2.3-rubocop:
requires: [confirm_config_and_documentation]
- ruby-2.4-rspec:
requires: [confirm_config_and_documentation]
- ruby-2.4-rubocop:
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ require:

AllCops:
DisplayCopNames: true
TargetRubyVersion: 2.3
TargetRubyVersion: 2.4
Exclude:
- 'vendor/**/*'
- 'spec/fixtures/**/*'
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* Fix `RSpec/FilePath` detection when absolute path includes test subject. ([@eitoball][])
* Add new `Capybara/VisibilityMatcher` cop. ([@aried3r][])
* Ignore String constants by `RSpec/Describe`. ([@AlexWayfer][])
* Drop support for ruby 2.3. ([@bquorning][])

## 1.38.1 (2020-02-15)

Expand Down
2 changes: 1 addition & 1 deletion rubocop-rspec.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Gem::Specification.new do |spec|

spec.version = RuboCop::RSpec::Version::STRING
spec.platform = Gem::Platform::RUBY
spec.required_ruby_version = '>= 2.3.0'
spec.required_ruby_version = '>= 2.4.0'

spec.require_paths = ['lib']
spec.files = Dir[
Expand Down

0 comments on commit cd6bc33

Please sign in to comment.